When developing containers that run code written by other developers it is prudent to safe-guard against System.exit calls. If a developer inadvertently calls System.exit and deploys their code to be run by your container, it brings down the container process completely. This can be controlled using the checkExit function call in SecurityManager.
According to the reference for SecurityManager checkExit:
This method is invoked for the current security manager by theexit method of class Runtime. A status of 0 indicates success; other values indicate various errors.Thus any call to exit invokes this method and we just have to throw an exception if we do not want the processing to continue further. We define our SecurityManager as below:
public class StopExitSecurityManager extends SecurityManager
{
private SecurityManager _prevMgr = System.getSecurityManager();
public void checkPermission(Permission perm)
{
}
public void checkExit(int status)
{
super.checkExit(status);
throw new ExitTrappedException(); //This throws an exception if an exit is called.
}
public SecurityManager getPreviousMgr() { return _prevMgr; }
}Now, we can provide a ease of use CodeControl class as below:
public class CodeControl
{
public CodeControl()
{
super();
}
public void disableSystemExit()
{
SecurityManager securityManager = new StopExitSecurityManager();
System.setSecurityManager(securityManager) ;
} public void enableSystemExit()
{
SecurityManager mgr = System.getSecurityManager();
if ((mgr != null) && (mgr instanceof StopExitSecurityManager))
{
StopExitSecurityManager smgr = (StopExitSecurityManager)mgr;
System.setSecurityManager(smgr.getPreviousMgr());
}
else
System.setSecurityManager(null);
}
}CodeControl can now be used as below:
CodeControl control = new CodeControl();
try
{
control.disableSystemExit();
//invoke the methods and other classes that are not allowed to call System.exit.
Object ret = invokeExecute(_method, runWith, parms);
}
finally
{
//finally enable exit
control.enableSystemExit();
}This will prevent the methods called within the disable and enable calls to call System.exit, but allow your code to call it without a problem.
What is ExitTrappedException? where is it defined? Is it imported?
Raji,
your
StopExitSecurityManagerclass has acheckPermissionmethod which grants *everything*.It would be safer to delegate to the previous manager to deal with non-exit permissions and deny exit directly.
A separate
checkExitmethod is not needed.public void checkPermission(Permission perm) {
final String EXIT_PERMISSION = “exitVM”;
if (perm instanceof RuntimePermission) {
if (perm.getName().startsWith(EXIT_PERMISSION)) {
// An exit permission is always denied.
throw new StopExitException();
}
}
if (_prevMgr != null) {
// Any other permission is checked by previous manger.
_prevMgr.checkPermission(perm);
}
}